Adds retry when failing to rename tmp folder to data#192
Merged
acdha merged 1 commit intoLibraryOfCongress:masterfrom Aug 14, 2025
kieranjol:temp-rename-retry
Merged
Adds retry when failing to rename tmp folder to data#192acdha merged 1 commit intoLibraryOfCongress:masterfrom kieranjol:temp-rename-retry
acdha merged 1 commit intoLibraryOfCongress:masterfrom
kieranjol:temp-rename-retry
Conversation
acdha
approved these changes
Aug 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a fix for #191 and #134. If a lock is placed on the tmp folder by antivirus or other tools on Windows, the renaming is not allowed and bagit exits with an error. This adds a try/except loop and retries after ten seconds. I'm very open to how this is handled, perhaps it should die after X number of retries or the timing should be changed.